Refactor the CLA GitHub Actions Scripts #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushuyu
force-pushed
the
main
branch
2 times, most recently
from
70b80e7 to
f2f4491
Compare
|
rejecting since we are going to rework the entire CI process with the new API end point let me know if you are interested to contribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the whole module and re-writes it in TypeScript to ensure robustness. ESBuild generates the final bundled JavaScript module, so the
node_modulesdirectory won't be checked into the repository.The Node.js runtime has also been upgraded to Node.js 20 to suppress the GitHub Actions warnings about deprecation.
lp_cla_check.pyhas been replaced with a TypeScript implementation to avoid Python dependencies (significant speed-up of the preparation steps).